Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Deprecation Warning #1658

Merged
merged 9 commits into from
Oct 28, 2017
Merged

Fix Deprecation Warning #1658

merged 9 commits into from
Oct 28, 2017

Conversation

poornagurram
Copy link
Contributor

assertequals to assertequal

@poornagurram
Fix Deprecation Warning
78a0354 
AssertEquals to AssertEqual
@poornagurram
Fix Deprecation Warning
d3c9e97 
Asser Equals to Assert Equal
@menshikh-iv
Copy link
Contributor

Good start @poornagurram, are you planning to continue?

@menshikh-iv menshikh-iv reopened this Oct 27, 2017
@poornagurram
Copy link
Contributor Author

Yes. I have set up things ready for this. :)

@poornagurram
Copy link
Contributor Author

you will merge this PR or shall I do other changes too in the same PR.

@menshikh-iv
Copy link
Contributor

@poornagurram please make all changes related with #1519 in current PR and ping me when you'll ready for review!

@poornagurram
Copy link
Contributor Author

Sure!!

@poornagurram
Fix Deprecation Warning
0b419cd 
AssertEquals to AssertEqual
@poornagurram
Fix Deprecation Warning
afe8c13 
AssertEquals to AssertEqual
@poornagurram
Copy link
Contributor Author

@menshikh-iv better now we can go for the review. As I am done with this type of warnings. Trying to explore more. will create a new pull request if I solve any.

@menshikh-iv
Copy link
Contributor

@poornagurram please fix remaining assertEquals:

ivan@P50:~/release/gensim$ find gensim/ -name "*.py" | xargs grep "assertEquals"
gensim/test/test_summarization.py:        self.assertEquals(summarize(""), u"")
gensim/test/test_summarization.py:        self.assertEquals(summarize("", split=True), [])
gensim/test/test_summarization.py:        self.assertEquals(summarize_corpus([]), [])
gensim/test/test_summarization.py:        self.assertEquals(summarize_corpus(corpus), [])
gensim/test/test_summarization.py:        self.assertEquals(summarize(text), u"")
gensim/test/test_summarization.py:        self.assertEquals(summarize(text, split=True), [])
gensim/test/test_utils.py:        self.assertEquals(utils.decode_htmlentities(body), expected)
gensim/test/test_utils.py:        self.assertEquals(utils.flatten(nested_list), expected)
gensim/test/test_utils.py:        self.assertEquals(utils.flatten(not_nested), expected)
gensim/test/test_tmdiff.py:        self.assertEquals(len(annotation), self.num_topics)
gensim/test/test_tmdiff.py:        self.assertEquals(len(annotation[0]), self.num_topics)
gensim/test/test_tmdiff.py:        self.assertEquals(len(annotation), self.num_topics)
gensim/test/test_tmdiff.py:                    self.assertEquals(diff_tokens, [])
gensim/test/test_tmdiff.py:                    self.assertEquals(len(int_tokens), self.n_ann_terms)
gensim/test/test_tmdiff.py:                self.assertEquals(diff_tokens, [])
gensim/test/test_tmdiff.py:                self.assertEquals(len(int_tokens), self.n_ann_terms)
gensim/test/test_word2vec.py:        self.assertEquals(len(limited_model_kv.syn0), 3)
gensim/test/test_word2vec.py:        self.assertEquals(binary_model_kv.syn0.nbytes, half_precision_model_kv.syn0.nbytes * 2)

@poornagurram
Copy link
Contributor Author

poornagurram commented Oct 28, 2017 •
edited
Loading

@menshikh-iv Changed all. Good to go.

@menshikh-iv
Copy link
Contributor

Thanks @poornagurram, congratz with the first contribution:1st_place_medal:

@menshikh-iv menshikh-iv merged commit 09cd946 into piskvorky:develop Oct 28, 2017
@poornagurram
Copy link
Contributor Author

@menshikh-iv woohoo!! Thank you. Looking for more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poornagurram @menshikh-iv